alexandrefimov commented on code in PR #16621:
URL: https://github.com/apache/iceberg/pull/16621#discussion_r3403180020
##########
parquet/src/main/java/org/apache/iceberg/parquet/ParquetFilters.java:
##########
@@ -29,19 +33,31 @@
import org.apache.iceberg.expressions.Expressions;
import org.apache.iceberg.expressions.Literal;
import org.apache.iceberg.expressions.UnboundPredicate;
+import org.apache.iceberg.relocated.com.google.common.collect.Maps;
+import org.apache.iceberg.types.Types;
+import org.apache.iceberg.util.DecimalUtil;
+import org.apache.iceberg.util.UUIDUtil;
+import org.apache.parquet.column.ColumnDescriptor;
import org.apache.parquet.filter2.compat.FilterCompat;
import org.apache.parquet.filter2.predicate.FilterApi;
import org.apache.parquet.filter2.predicate.FilterPredicate;
import org.apache.parquet.filter2.predicate.Operators;
import org.apache.parquet.io.api.Binary;
+import org.apache.parquet.schema.MessageType;
+import org.apache.parquet.schema.PrimitiveType;
class ParquetFilters {
private ParquetFilters() {}
- static FilterCompat.Filter convert(Schema schema, Expression expr, boolean
caseSensitive) {
+ static FilterCompat.Filter convert(
+ MessageType parquetSchema, Expression expr, boolean caseSensitive) {
+ Schema schema = ParquetSchemaUtil.convert(parquetSchema);
Review Comment:
Thanks, good catch. I pushed cd8114137, which applies Expressions.rewriteNot
before converting to a Parquet filter and adds
skipsNegatedDecimalLiteralWithIncompatibleScale next to the incompatible-scale
coverage. I re-ran :iceberg-parquet:test --tests
org.apache.iceberg.parquet.TestParquetFilters and
:iceberg-parquet:spotlessCheck with JDK 21.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
