nssalian commented on code in PR #1182:
URL: https://github.com/apache/iceberg-go/pull/1182#discussion_r3405046760
##########
table/transaction_test.go:
##########
@@ -73,6 +73,15 @@ func (s *SparkIntegrationTestSuite) SetupTest() {
s.cat = cat
}
+func (s *SparkIntegrationTestSuite) requireSpark4() {
+ s.T().Helper()
+ major, err := recipe.SparkMajorVersion(s.T())
+ s.Require().NoError(err, "spark version extraction failed")
+ if major < 4 {
+ s.T().Skipf("requires Spark 4+ (running Spark %d)", major)
+ }
+}
+
func (s *SparkIntegrationTestSuite) TestSetProperties() {
icebergSchema := iceberg.NewSchema(0,
Review Comment:
Agreed. I moved `requireSpark4()` to the first line of both tests and it
should resolve the rerun-conflict on `go_variant_events` / `go_unknown_table`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
