rymurr commented on pull request #1875: URL: https://github.com/apache/iceberg/pull/1875#issuecomment-745286527
I had another look at this, I am not super happy with the way the catalog name is chosen nor with the way the Hive catalog is instantiated in `CatalogUtil`. However there is very little code re-use and the Spark2 behaviour will be very similar to Spark3 wrt catalogs and identifiers. The surface area of this PR also has decreased (most of it is moving methods around). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
