smaheshwar-pltr commented on code in PR #16796:
URL: https://github.com/apache/iceberg/pull/16796#discussion_r3406368765
##########
core/src/main/java/org/apache/iceberg/TableMetadata.java:
##########
@@ -1800,12 +1800,18 @@ private static List<MetadataLogEntry> addPreviousFile(
int maxSize =
Math.max(
- 1,
+ 0,
PropertyUtil.propertyAsInt(
properties,
TableProperties.METADATA_PREVIOUS_VERSIONS_MAX,
TableProperties.METADATA_PREVIOUS_VERSIONS_MAX_DEFAULT));
+ // A max of 0 means no previous metadata files are tracked, so the
metadata log is empty and
+ // the file being superseded is not retained.
Review Comment:
Remove comment
##########
core/src/main/java/org/apache/iceberg/TableMetadata.java:
##########
@@ -1800,12 +1800,18 @@ private static List<MetadataLogEntry> addPreviousFile(
int maxSize =
Math.max(
- 1,
+ 0,
PropertyUtil.propertyAsInt(
properties,
TableProperties.METADATA_PREVIOUS_VERSIONS_MAX,
TableProperties.METADATA_PREVIOUS_VERSIONS_MAX_DEFAULT));
+ // A max of 0 means no previous metadata files are tracked, so the
metadata log is empty and
+ // the file being superseded is not retained.
Review Comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
