wypoon commented on a change in pull request #1782: URL: https://github.com/apache/iceberg/pull/1782#discussion_r543618748
########## File path: spark3/src/main/java/org/apache/iceberg/spark/source/SparkMergeScan.java ########## @@ -0,0 +1,179 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg.spark.source; + +import java.io.IOException; +import java.util.Collections; +import java.util.List; +import java.util.Map; +import java.util.Objects; +import org.apache.iceberg.CombinedScanTask; +import org.apache.iceberg.FileScanTask; +import org.apache.iceberg.Schema; +import org.apache.iceberg.Table; +import org.apache.iceberg.TableScan; +import org.apache.iceberg.encryption.EncryptionManager; +import org.apache.iceberg.exceptions.RuntimeIOException; +import org.apache.iceberg.expressions.Expression; +import org.apache.iceberg.io.CloseableIterable; +import org.apache.iceberg.io.FileIO; +import org.apache.iceberg.relocated.com.google.common.collect.Lists; +import org.apache.iceberg.spark.Spark3Util; +import org.apache.iceberg.util.PropertyUtil; +import org.apache.iceberg.util.TableScanUtil; +import org.apache.spark.broadcast.Broadcast; +import org.apache.spark.sql.connector.read.Statistics; +import org.apache.spark.sql.util.CaseInsensitiveStringMap; + +import static org.apache.iceberg.TableProperties.SPLIT_LOOKBACK; +import static org.apache.iceberg.TableProperties.SPLIT_LOOKBACK_DEFAULT; +import static org.apache.iceberg.TableProperties.SPLIT_OPEN_FILE_COST; +import static org.apache.iceberg.TableProperties.SPLIT_OPEN_FILE_COST_DEFAULT; +import static org.apache.iceberg.TableProperties.SPLIT_SIZE; +import static org.apache.iceberg.TableProperties.SPLIT_SIZE_DEFAULT; + +class SparkMergeScan extends SparkBatchScan { + + private final Table table; + private final boolean ignoreResiduals; + private final Schema expectedSchema; + private final Long snapshotId; + private final Long splitSize; + private final Integer splitLookback; + private final Long splitOpenFileCost; + + // lazy variables + private List<FileScanTask> files = null; // lazy cache of files + private List<CombinedScanTask> tasks = null; // lazy cache of tasks + + SparkMergeScan(Table table, Broadcast<FileIO> io, Broadcast<EncryptionManager> encryption, + boolean caseSensitive, boolean ignoreResiduals, Schema expectedSchema, + List<Expression> filters, CaseInsensitiveStringMap options) { + + super(table, io, encryption, caseSensitive, expectedSchema, filters, options); + + this.table = table; Review comment: Can you please explain why `SparkMergeScan` has its own private `table` field? Afaics, it is only used in `files()`, where `table.newScan()` is called. Why can you not call `table().newScan()` instead? If you can, then there is no need for this private `table` field; you'll only ever use the `table` in the superclass, `SparkBatchScan`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
