kevinjqliu commented on code in PR #16798:
URL: https://github.com/apache/iceberg/pull/16798#discussion_r3408549397
##########
site/docs/assets/stylesheets/extra.css:
##########
@@ -231,6 +231,10 @@ header .md-search__input::placeholder {
font-family: "Source Sans Pro", sans-serif;
}
+.md-typeset table code {
Review Comment:
need to properly render table cells on the same line, otherwise longer
strings like "decimal(P,S)" might be split into multiple lines
<img width="601" height="80" alt="Image"
src="https://github.com/user-attachments/assets/6e602635-b43e-47cd-ba77-b2623b5eba60";
/>
##########
format/spec.md:
##########
@@ -268,7 +268,7 @@ Supported primitive types are defined in the table below.
Primitive types added
| | **`long`** | 64-bit signed integers
|
|
| | **`float`** | [32-bit IEEE
754](https://en.wikipedia.org/wiki/IEEE_754) floating point | Can promote to
double |
| | **`double`** | [64-bit IEEE
754](https://en.wikipedia.org/wiki/IEEE_754) floating point |
|
-| | **`decimal(P,S)`** | Fixed-point decimal; precision P,
scale S | Scale is fixed, precision must be 38
or less |
+| | **`decimal(P, S)`** | Fixed-point decimal; precision P,
scale S | Scale is fixed, precision must be 38
or less |
Review Comment:
changed all `decimal(P,S)` to `decimal(P, S)`
##########
format/spec.md:
##########
Review Comment:
removed non-canonical example `decimal(9,2)`
and add a sentence below to explain that readers should accept from without
space, `decimal(9,2)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
