ebyhr commented on code in PR #3478:
URL: https://github.com/apache/iceberg-python/pull/3478#discussion_r3409024829
##########
pyiceberg/table/puffin.py:
##########
@@ -30,6 +32,12 @@
EMPTY_BITMAP = FrozenBitMap()
MAX_JAVA_SIGNED = int(math.pow(2, 31)) - 1
PROPERTY_REFERENCED_DATA_FILE = "referenced-data-file"
+_DV_BLOB_LENGTH = struct.Struct(">I")
+_DV_BLOB_MAGIC = struct.Struct("<I")
+_DV_BLOB_CRC = struct.Struct(">I")
+_DV_BLOB_MAGIC_NUMBER = 1681511377
+_ROARING_BITMAP_COUNT_SIZE_BYTES = 8
+_DV_BLOB_MIN_SIZE_BYTES = _DV_BLOB_LENGTH.size + _DV_BLOB_MAGIC.size +
_ROARING_BITMAP_COUNT_SIZE_BYTES + _DV_BLOB_CRC.size
Review Comment:
+1 to decoupling the logic from this class. I submitted a PR yesterday
(#3491) that addresses this issue. The code still resides in the same file, but
I'll create a separate file named `deletion_vector.py` if necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
