zhjwpku commented on code in PR #716: URL: https://github.com/apache/iceberg-cpp/pull/716#discussion_r3410561070
########## src/iceberg/catalog/rest/json_serde.cc: ########## @@ -903,13 +903,21 @@ Result<CommitTableRequest> CommitTableRequestFromJson(const nlohmann::json& json ICEBERG_ASSIGN_OR_RAISE(auto requirements_json, Review Comment: I took a look at Java's `UpdateTableRequest.fromJson`. It doesn't appear to error when `REQUIREMENTS` or `UPDATES` is missing from the JSON object. In contrast, we're using `GetJsonValue` here, which would result in a `JsonParseError` under the same conditions. Should we align with the Java(using GetJsonValueOptional)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
