nastra commented on code in PR #16784: URL: https://github.com/apache/iceberg/pull/16784#discussion_r3412185237
########## site/docs/contribute.md: ########## @@ -478,6 +478,12 @@ This helps separate logical sections of the code, making it easier to read and d ## Testing +### Conventions and recommendations + +- Test class names must start with `Test`, for example `TestExample`. +- Recommend omitting the `public` modifier for test classes, test methods, and lifecycle methods. +- Recommend omitting the `test` prefix for test methods. Review Comment: ```suggestion - Omit the `test` prefix for newly added test methods. ``` ########## site/docs/contribute.md: ########## @@ -478,6 +478,12 @@ This helps separate logical sections of the code, making it easier to read and d ## Testing +### Conventions and recommendations + +- Test class names must start with `Test`, for example `TestExample`. +- Recommend omitting the `public` modifier for test classes, test methods, and lifecycle methods. Review Comment: ```suggestion - Omit the `public` modifier for test classes, test methods, and lifecycle methods for newly added tests. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
