leeyam24 commented on code in PR #16669:
URL: https://github.com/apache/iceberg/pull/16669#discussion_r3412319507
##########
core/src/test/java/org/apache/iceberg/TestRewriteTablePathUtil.java:
##########
@@ -281,4 +281,50 @@ public void
testRewritingMultiplePositionDeleteEntriesWithinManifestFile() throw
assertThat(deleteFileRewriteResult.toRewrite()).hasSize(2);
}
+
+ @TestTemplate
+ public void testDeletedPositionDeleteEntriesAreNotRewritten() throws
IOException {
+ assumeThat(formatVersion)
+ .as("Delete files only work for format version 2")
+ .isGreaterThanOrEqualTo(2);
Review Comment:
Wouldn't it make more sense for it to be `.isEqualTo(2);` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
