rdblue commented on a change in pull request #1942:
URL: https://github.com/apache/iceberg/pull/1942#discussion_r544570662



##########
File path: core/src/test/java/org/apache/iceberg/TestTableMetadata.java
##########
@@ -501,7 +501,7 @@ public void testNewTableMetadataReassignmentAllIds() throws 
Exception {
 
     PartitionSpec spec = PartitionSpec.builderFor(schema).withSpecId(5)
         .add(3, 1005, "x_partition", "bucket[4]")
-        .add(5, 1005, "z_partition", "bucket[8]")
+        .add(5, 1003, "z_partition", "bucket[8]")

Review comment:
       The intent is to check whether the IDs are reassigned. The spec builder 
may reject duplicate IDs.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to