xanderbailey commented on code in PR #2584:
URL: https://github.com/apache/iceberg-rust/pull/2584#discussion_r3415038377


##########
crates/iceberg/src/scan/context.rs:
##########
@@ -136,6 +136,7 @@ impl ManifestEntryContext {
             // TODO: Extract name_mapping from table metadata property 
"schema.name-mapping.default"
             .with_name_mapping(None)
             .with_case_sensitive(self.case_sensitive)
+            
.with_key_metadata(self.manifest_entry.data_file.key_metadata().map(Box::from))

Review Comment:
   The metadata here is very small (max 32 byte keys + aad) so it's a pretty 
small cost and hard to avoid with the current setup unfortunately. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to