jackye1995 commented on a change in pull request #1918:
URL: https://github.com/apache/iceberg/pull/1918#discussion_r544645052



##########
File path: build.gradle
##########
@@ -1128,6 +1128,12 @@ project(':iceberg-nessie') {
 
 }
 
+project(':iceberg-crypto') {

Review comment:
       I wonder if it is better to directly have all the code in `iceberg-core` 
module under the `org.apache.iceberg.encryption`, since no one would use the 
`crypto` module independently, and there is no other third-party dependencies 
pulled in.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to