plusplusjiajia commented on code in PR #3120: URL: https://github.com/apache/iceberg-python/pull/3120#discussion_r3417872326
########## mkdocs/docs/configuration.md: ########## @@ -396,6 +398,7 @@ The RESTCatalog supports pluggable authentication via the `auth` configuration b - `custom`: Custom authentication manager (requires `auth.impl`). - `google`: Google Authentication support - `entra`: Microsoft Entra ID (Azure AD) authentication support +- `sigv4`: AWS SigV4 request signing, optionally wrapping a delegate auth type. Review Comment: @rambleraptor Thanks for the review, @rambleraptor! Went with sigv4 to match Iceberg Java's rest.auth.type=sigv4 ([AUTH_TYPE_SIGV4](https://github.com/apache/iceberg/blob/main/core/src/main/java/org/apache/iceberg/rest/auth/AuthProperties.java#L30)) — keeps catalog configs portable across the Java and Python clients. If AWS adds more signing mechanisms, Java would likely add a new type and we'd follow; happy to switch to aws if you'd rather have the broader bucket. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
