plusplusjiajia commented on PR #750: URL: https://github.com/apache/iceberg-cpp/pull/750#issuecomment-4714783354
Thanks for the ping @wgtmac. Read through it — the session-aware split (a root with context/table-scoped views) reads well, and it's a cleaner home for table-scoped FileIO than what I did in [#719](https://github.com/apache/iceberg-cpp/pull/719). #719 already covers the TODO(gangwu) here: parsing storage-credentials into LoadTableResult (separate files, no conflict) + building the per-table S3 FileIO. I'd land the parsing independently, then rebase the binding onto this as the TableFileIO impl once it merges. One design question: ValidateNoFileIOConfig fails closed on any non-auth key, but LoadTableResponse.config can carry non-auth, non-FileIO settings too — reject only recognized FileIO/storage keys and pass the rest through? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
