wgtmac commented on code in PR #747:
URL: https://github.com/apache/iceberg-cpp/pull/747#discussion_r3418027063
##########
src/iceberg/expression/strict_metrics_evaluator.cc:
##########
@@ -532,9 +532,12 @@ Result<std::unique_ptr<StrictMetricsEvaluator>>
StrictMetricsEvaluator::Make(
}
Result<bool> StrictMetricsEvaluator::Evaluate(const DataFile& data_file) const
{
- if (data_file.record_count <= 0) {
+ if (data_file.record_count == 0) {
return kRowsMustMatch;
}
+ // A negative record count is used as a sentinel for an unknown row count
(e.g. when
Review Comment:
Specifically, `-1` is the sentinel value. So is it better to error out on
other negative values just in case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
