ebyhr commented on code in PR #3517:
URL: https://github.com/apache/iceberg-python/pull/3517#discussion_r3424941654
##########
tests/test_transforms.py:
##########
@@ -255,6 +257,11 @@ def test_identity_transform_unknown_type() -> None:
assert IdentityTransform().to_human_string(UnknownType(), None) == "null"
[email protected]("type_var", [GeometryType(), GeographyType()])
+def test_identity_transform_unsupported_type(type_var: PrimitiveType) -> None:
+ assert not IdentityTransform().can_transform(type_var)
+
+
Review Comment:
We could improve the test coverage for other methods such as `transform`.
If we want to test `can_transform` only, I suggest renaming to
`test_identity_can_transform_unsupported_type`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
