nastra commented on code in PR #16819:
URL: https://github.com/apache/iceberg/pull/16819#discussion_r3425893439
##########
spark/v4.1/spark/src/main/java/org/apache/iceberg/spark/SparkSessionCatalog.java:
##########
@@ -428,15 +430,34 @@ public UnboundFunction loadFunction(Identifier ident)
throws NoSuchFunctionExcep
public Identifier[] listViews(String... namespace) {
try {
if (null != asViewCatalog) {
- return asViewCatalog.listViews(namespace);
+ return ArrayUtil.concat(
+ Identifier.class,
+ asViewCatalog.listViews(namespace),
+ listSessionCatalogViews(namespace));
} else if (isViewCatalog()) {
- getSessionCatalog().listViews(namespace);
Review Comment:
@manuzhang I think we should first fix this one independently. Can you
please open a separate PR and add a return here with some tests?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
