xanderbailey commented on code in PR #2666:
URL: https://github.com/apache/iceberg-rust/pull/2666#discussion_r3426342775


##########
crates/iceberg/src/transaction/snapshot.rs:
##########
@@ -255,7 +255,6 @@ impl<'a> SnapshotProducer<'a> {
         let builder = ManifestWriterBuilder::new(
             output_file,
             Some(self.snapshot_id),
-            self.key_metadata.clone(),

Review Comment:
   The metadata here comes from the fast append action which I think is also 
wrong but I'll remove that in a further follow up PR to keep these refactors 
targeted. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to