manuzhang commented on code in PR #721:
URL: https://github.com/apache/iceberg-cpp/pull/721#discussion_r3426504932
##########
src/iceberg/update/merging_snapshot_update.h:
##########
@@ -288,6 +288,14 @@ class ICEBERG_EXPORT MergingSnapshotUpdate : public
SnapshotUpdate {
const std::shared_ptr<Snapshot>& parent, std::shared_ptr<FileIO> io,
bool case_sensitive = true);
+ /// \brief Return an error if a staged deletion vector conflicts with a
deletion
+ /// vector added since starting_snapshot_id.
+ Status ValidateAddedDVs(const TableMetadata& metadata,
Review Comment:
It's already protected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
