hkwi commented on code in PR #16843:
URL: https://github.com/apache/iceberg/pull/16843#discussion_r3427548652
##########
kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/channel/CommitterImpl.java:
##########
@@ -237,4 +281,13 @@ private void stopCoordinator() {
coordinatorThread = null;
}
}
+
+ private RuntimeException appendFailure(RuntimeException failure,
RuntimeException next) {
Review Comment:
Thank you, that makes sense. I kept the follow-up small and moved the merge
logic into a package-private static helper on the existing `Channel` class in
c852c178a, then reused it from `CommitterImpl`, `Channel`, `Worker`, and
`CoordinatorThread`. That keeps the suppression handling in one place without
adding another helper class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
