rdblue commented on a change in pull request #1939:
URL: https://github.com/apache/iceberg/pull/1939#discussion_r544751813
##########
File path:
flink/src/main/java/org/apache/iceberg/flink/sink/IcebergFilesCommitter.java
##########
@@ -85,9 +88,9 @@
// iceberg table when the next checkpoint happen.
private final NavigableMap<Long, byte[]> dataFilesPerCheckpoint =
Maps.newTreeMap();
- // The data files cache for current checkpoint. Once the snapshot barrier
received, it will be flushed to the
+ // The completed files cache for current checkpoint. Once the snapshot
barrier received, it will be flushed to the
// 'dataFilesPerCheckpoint'.
- private final List<DataFile> dataFilesOfCurrentCheckpoint =
Lists.newArrayList();
+ private final List<WriteResult> writeResultsOfCurrentCkpt =
Lists.newArrayList();
Review comment:
Is it correct for this to be a list of write results if a write result
keeps track of a list of data files and a list of delete files?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
