mxm commented on code in PR #16844:
URL: https://github.com/apache/iceberg/pull/16844#discussion_r3430247166
##########
flink/v2.1/flink/src/test/java/org/apache/iceberg/flink/maintenance/operator/OperatorTestBase.java:
##########
@@ -450,6 +450,19 @@ private DeleteFile writeEqualityDelete(Table table,
Integer id, String oldData)
SCHEMA_WITH_PRIMARY_KEY);
}
+ protected DeleteFile writePosDeleteFile(Table table, String dataFilePath,
long pos)
Review Comment:
True, this test helper method is unused in this PR, though it is used in the
full set of changes in #15996. Nevertheless, I added a dedicated reader test
which utilizes this test method to assert V2 positional deletes are rejected at
the reader level.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
