anoopj commented on PR #16823: URL: https://github.com/apache/iceberg/pull/16823#issuecomment-4734351758
Sorry, I missed the AMT sync this week. > Seems reasonable not to bump dv snapshot ID when setting deleted and replaced positions, because they are fields that relevant for the current snapshot only and we don't carry them forward anyway. `dv_snapshot_id` and `deleted/replaced_positions` have different lifetimes. The latter gets dropped in the next snapshot, while `dv_snapshot_id` tells us which snapshot changed the manifest DV (this is useful information). So it doesn't look redundant? Setting it is also consistent with how `dv_snapshot_id` works on data DVs. The corresponding `REPLACED` entry with the old DV entry is transient, but `dv_snapshot_id` on the `MODIFIED` entry sticks. cc @stevenzwu who originally suggested changing `dv_snapshot_id` for manifest DV changes (not sure Steven was at the sync) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
