tanmayrauth commented on PR #1218: URL: https://github.com/apache/iceberg-go/pull/1218#issuecomment-4735969571
Thanks for the thorough review! I've pushed a commit addressing all three points. The applyDayTransformDates godoc and the test rationale now cite apache/iceberg#16446 (the day transform's date result type and note [1] requiring readers to accept the plain-int encoding), so the normalization reads as spec-mandated rather than convention. For the atype.Date fallthrough, I kept return v but added a comment explaining why it's unreachable with twmb/avro and warning against adding a coercing guard that would reintroduce #1200. Happy to switch that to a loud failure (panic/typed error) instead if you'd prefer, let me know! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
