ebyhr commented on code in PR #3523:
URL: https://github.com/apache/iceberg-python/pull/3523#discussion_r3432275426
##########
tests/utils/test_decimal.py:
##########
@@ -42,8 +42,29 @@ def test_decimal_required_bytes() -> None:
assert "(0, 40]" in str(exc_info.value)
+def test_bytes_required() -> None:
+ # Positive values and the negative values just past a byte boundary are
unaffected.
+ assert bytes_required(0) == 1
+ assert bytes_required(127) == 1
+ assert bytes_required(128) == 2
+ assert bytes_required(-127) == 1
+ assert bytes_required(-129) == 2
+ # The most-negative value that fits in N bytes (-2**(8N-1)) must require
exactly N bytes,
+ # not N + 1. These are the cases the previous (value.bit_length() + 8) //
8 formula overcounted.
+ assert bytes_required(-128) == 1
+ assert bytes_required(-32768) == 2
+ assert bytes_required(-8388608) == 3
+ # The same applies when the unscaled value comes from a Decimal.
+ assert bytes_required(Decimal("-1.28")) == 1
+ assert bytes_required(Decimal("-327.68")) == 2
Review Comment:
Can we add a positive Decimal just in case? `Decimal("1.27")`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
