gerinsp commented on issue #1207: URL: https://github.com/apache/iceberg-go/issues/1207#issuecomment-4737653951
Thanks, that makes sense. I agree that `DeleteEquality` could be confused with `Delete(filter)`. I have no strong preference on naming, but `CommitEqualityDeletes` sound clear. I'll keep this as a thin convenience wrapper over `WriteEqualityDeletes` and `RowDelta`, without duplicating validation or changing `DeleteFilter` semantics. From the current implementation, `RowDelta` already applies conflict validation based on `write.delete.isolation-level`, with serializable isolation as a default . I'll add concurrent-writter regression test to verify that the convenience API inherits those stale-snapshot/conflict-detection semantics. For the initial contribution, I'll keep the scope narrow and delete-only. Updates requiring delete and append in one snapshot can continue using the lower-level `RowDelta` API. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
