adutra commented on PR #15989: URL: https://github.com/apache/iceberg/pull/15989#issuecomment-4741823505
@nastra also the problem is broader ecosystem compatibility. Using `decodeString` to decode `encodePathSegment` only works because in Java, `encodePathSegment` would encode `+` as `%20`. But _RFC 3986 does not require this sign to be percent-encoded_. Other clients could send `+` unencoded; and `decodeString` would wrongly decode that as a space, not a plus sign. For a general RFC 3986-compliant server that may receive requests from any client written in any language, `decodeString` is incorrect for path segments; `decodePathSegment` is the right decoder. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
