wgtmac commented on code in PR #701:
URL: https://github.com/apache/iceberg-cpp/pull/701#discussion_r3437097105
##########
src/iceberg/catalog/memory/in_memory_catalog.h:
##########
@@ -19,12 +19,15 @@
#pragma once
+#include <memory>
#include <shared_mutex>
#include "iceberg/catalog.h"
namespace iceberg {
+class MetricsReporter;
Review Comment:
Should we add this forward declaration to `iceberg/type_fwd.h`?
##########
src/iceberg/catalog/rest/rest_catalog.cc:
##########
@@ -185,7 +188,7 @@ Result<std::shared_ptr<RestCatalog>> RestCatalog::Make(
}
RestCatalog::RestCatalog(RestCatalogProperties config, std::shared_ptr<FileIO>
file_io,
- std::unique_ptr<HttpClient> client,
+ std::shared_ptr<HttpClient> client,
Review Comment:
Why this change is required?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
