kevinjqliu commented on PR #16566: URL: https://github.com/apache/iceberg/pull/16566#issuecomment-4744116825
Thanks for working on this. I agree with the goal of reducing GH Actions usage. My main concern is maintainability. This adds a fairly large hand-maintained CI planner with path regexes, workflow routing, version selection, and CVE artifact mapping all in Bash. As the repo changes, it seems easy to miss updating this and accidentally skip important CI coverage. So +1 on the direction, but I’m not sure this implementation is safe to maintain as-is. I think we should first agree on how we want to keep this selection logic understandable and hard to accidentally under-run. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
