zeroshade commented on code in PR #1198:
URL: https://github.com/apache/iceberg-go/pull/1198#discussion_r3438981685
##########
transforms.go:
##########
@@ -477,6 +484,18 @@ func (t TruncateTransform) Transformer(src Type)
(func(any) any, error) {
ErrInvalidArgument, src)
}
+func truncateString(s string, width int) string {
+ for idx := range s {
+ if width == 0 {
+ return s[:idx]
Review Comment:
Isn't this just the same exact thing as we already had? I'm not clear on how
this is different at all to the existing code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
