wgtmac commented on code in PR #760:
URL: https://github.com/apache/iceberg-cpp/pull/760#discussion_r3440101305
##########
cmake_modules/IcebergThirdpartyToolchain.cmake:
##########
@@ -421,6 +421,62 @@ function(resolve_croaring_dependency)
PARENT_SCOPE)
endfunction()
+# ----------------------------------------------------------------------
+# utf8proc
+
+function(resolve_utf8proc_dependency)
+ prepare_fetchcontent()
+
+ if(DEFINED ENV{ICEBERG_UTF8PROC_URL})
+ set(UTF8PROC_URL "$ENV{ICEBERG_UTF8PROC_URL}")
+ else()
+ set(UTF8PROC_URL
+
"https://github.com/JuliaStrings/utf8proc/archive/refs/tags/v2.10.0.tar.gz";)
+ endif()
+
+ fetchcontent_declare(utf8proc
+ ${FC_DECLARE_COMMON_OPTIONS}
+ URL ${UTF8PROC_URL}
+ FIND_PACKAGE_ARGS
+ NAMES
+ utf8proc
+ CONFIG)
+ fetchcontent_makeavailable(utf8proc)
+
+ if(utf8proc_SOURCE_DIR)
+ if(NOT TARGET utf8proc::utf8proc)
+ add_library(utf8proc::utf8proc INTERFACE IMPORTED)
+ target_link_libraries(utf8proc::utf8proc INTERFACE utf8proc)
+ target_include_directories(utf8proc::utf8proc INTERFACE
${utf8proc_SOURCE_DIR})
+ endif()
+
+ set(UTF8PROC_VENDORED TRUE)
Review Comment:
`utf8proc` is licensed under the permissive MIT License (along with some
Unicode data under a similarly permissive license). We need to update the
LICENSE File by adding a separator at the bottom similar to this:
```
---
This product bundles utf8proc, which is available under the MIT License:
Copyright © 2014-2021 by Steven G. Johnson, Jiahao Chen, Tony Kelman, Jonas
Fonseca, and other contributors listed in the git history.
Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
in the Software without restriction, including without limitation the rights to
use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies
of the Software... (include the rest of the utf8proc MIT license text here)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
