brgr-s commented on PR #2620: URL: https://github.com/apache/iceberg-rust/pull/2620#issuecomment-4752604484
@CTTY I noticed that there might currently a small detail missing in `update_snapshot_summaries` (`/iceberg/src/spec/snapshot_summary.rs`): currently `Operation::Replace` is not allowed. I created a small patch including a test here: https://github.com/lakekeeper/iceberg-rust/commit/46a1cc1bc8b5bf5ca9713557cfb1dde058c455a6 It is based of your working branch for this PR. The test was creating comparing snapshot summaries before and after compacting a table with Spark. I will be testing this PR soon by implementing a very simple bin-pack compaction using iceberg-rust. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
