jackye1995 commented on a change in pull request #1844:
URL: https://github.com/apache/iceberg/pull/1844#discussion_r545315401
##########
File path: aws/src/main/java/org/apache/iceberg/aws/AwsProperties.java
##########
@@ -131,6 +170,8 @@
private String glueCatalogId;
private boolean glueCatalogSkipArchive;
+ private AwsClientFactory clientFactory;
Review comment:
`UrlConnectionHttpClient.create()` is a static final, should not affect
serialization.
I think the client factory has to be serializable anyway, because
`AwsClientFactory::s3`will be used as the supplier for s3 client in `S3FileIO`.
Is there any use case that you think need it to be not serializable?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
