nssalian opened a new pull request, #16881: URL: https://github.com/apache/iceberg/pull/16881
Continues [#15494](https://github.com/apache/iceberg/pull/15494) (@mxm) and [#15176](https://github.com/apache/iceberg/pull/15176) (@manuzhang) ## Summary Converts statement-form `switch` blocks in `iceberg-core` to expression-form (arrow syntax). Eliminates `StatementSwitchToExpressionSwitch` ErrorProne warnings and removes the risk of accidental fall-through in the converted code. ## Rationale for the change Per the [[DISCUSS] Switching to new switches](https://lists.apache.org/thread/k2cg9v6rxs8lb74qbok166k68h1r0f3k) dev list thread, consensus was option 2 - merge sweeping syntax changes shortly before the release. Targeting 1.12. ## Changes - `iceberg-core` only. Pattern-matching for `instanceof` - I'll create a separate follow-up PR. - The diff was generated by ErrorProne's auto-patcher (`-XepPatchChecks:StatementSwitchToExpressionSwitch -XepPatchLocation:IN_PLACE`), then `spotlessApply`, plus a small manual cleanup in `PrimitiveWrapper.sizeInBytes()` to keep trailing comments inline. ## Test - locally ran the core tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
