zhjwpku commented on code in PR #746:
URL: https://github.com/apache/iceberg-cpp/pull/746#discussion_r3445310006
##########
src/iceberg/json_serde.cc:
##########
@@ -307,6 +300,15 @@ nlohmann::json ToJson(const SchemaField& field) {
if (!field.doc().empty()) {
json[kDoc] = field.doc();
}
+ // Defaults are validated to be primitive literals matching the field type,
so
Review Comment:
Should we add a round-trip serde test for default values?
##########
src/iceberg/test/resources/TableMetadataV3Valid.json:
##########
@@ -0,0 +1,123 @@
+{
Review Comment:
This metadata file seems not being used anywhere.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
