badalprasadsingh commented on PR #1214: URL: https://github.com/apache/iceberg-go/pull/1214#issuecomment-4758391967
Hey @zeroshade, 1. Removed the `parquet/metadata` import. 2. The exported fields are now format-agnostic — `iceberg.FileFormat` selects the implementation and Metadata `any` carries the format-specific in-memory metadata object. 3. Tried to keep the dispatch generic via the internal `FileFormat` something similar to what we have in `writer.go`. 4. Kept `Metadata` as any. Please take a look whenever you are free. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
