kevinjqliu opened a new issue, #3541: URL: https://github.com/apache/iceberg-python/issues/3541
`scan_plan_helper` should be internal. it was introduced in https://github.com/apache/iceberg-python/commit/d99936a6aa1758577c27532eb4f91bd15053ce92#diff-23e8153e0fd497a9212215bd2067068f3b56fa071770c7ef326db3d3d03cee9bR1946 Previously, the local planning path was: ``` plan_files() -> _plan_files_local() -> self.scan_plan_helper() ``` With this refactor, local planning now goes through the extracted planner directly: ``` plan_files() -> _plan_files_local() -> self._manifest_planner.plan_files(...) ``` Since scan_plan_helper is an internal helper rather than a public extension point, this change seems fine. We should follow up and append an `_` to the function name _Originally posted by @kevinjqliu in https://github.com/apache/iceberg-python/pull/3511#discussion_r3447191936_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
