lawofcycles commented on code in PR #3320: URL: https://github.com/apache/iceberg-python/pull/3320#discussion_r3448472156
########## tests/table/test_commit_retry.py: ########## @@ -0,0 +1,724 @@ +# Licensed to the Apache Software Foundation (ASF) under one Review Comment: Added two branch tests (`test_commit_retry_on_non_main_branch` and `test_commit_retry_delete_on_non_main_branch`). Writing these actually exposed a bug in `_rebuild_snapshot_updates` where `catalog_head_snapshot_id` was fetched via `current_snapshot()`, which always returns the main branch HEAD. For non-main branches, validation would fail because `ancestors_between` could not trace the ancestry from the branch's starting snapshot to main's HEAD. Fixed by using `snapshot_by_name(target_branch)` instead. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
