kevinjqliu commented on PR #16882: URL: https://github.com/apache/iceberg/pull/16882#issuecomment-4762798971
> I think we're taking on a fair bit of burden for a relatively narrow win. The key has to stay a complete description of everything that affects the written files, or I think we may silently hand back the wrong ones. +1 while its great to reduce resource utilization for CI, I would like to prioritize test correctness, readability, and maintainability above all else. If that cost us more resources, then so be it 😄 I do think there are other opportunity to pursue. In general, I think we should modify the tests themselves only as a last resort, and only when its not affecting the semantic or correctness of those tests. In this case I think it might be a good idea to revert #16740 and also forgo this PR. I can raise this in the devlist thread about CI utilization if necessary -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
