fallintoplace opened a new pull request, #1242: URL: https://github.com/apache/iceberg-go/pull/1242
## Summary This makes the equality-delete fast-path encoders write the same null tag as the generic encoder before reading raw Arrow values. Without that guard, nullable numeric/date/time/timestamp keys could be encoded as non-null zero or epoch-like values. The tests cover the raw fast-path encoders directly and scan-level equality deletes where a null delete key must remove only null rows, not non-null zero or epoch rows. ## Testing - `go test ./table -run 'TestEqualityDeleteNullable|TestMakeColEncoderMatchesGenericForNullFastPathTypes' -count=1` - `git diff --check` - `go test ./table -count=1` - `go run github.com/golangci/golangci-lint/v2/cmd/[email protected] run --timeout=10m ./table/...` - `go test ./... -count=1` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
