rambleraptor commented on code in PR #3546:
URL: https://github.com/apache/iceberg-python/pull/3546#discussion_r3449078054
##########
pyiceberg/expressions/literals.py:
##########
@@ -325,6 +325,10 @@ def _(self, _: DoubleType) -> Literal[float]:
@to.register(DateType)
def _(self, _: DateType) -> Literal[int]:
+ if IntegerType.max < self.value:
Review Comment:
nit: consider swapping the order on both of these for readability.
If self.value > Integers.max is more intuitive to read.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
