thswlsqls commented on code in PR #16886:
URL: https://github.com/apache/iceberg/pull/16886#discussion_r3449149928
##########
dell/src/main/java/org/apache/iceberg/dell/ecs/EcsURI.java:
##########
@@ -35,7 +35,7 @@ class EcsURI {
private final String name;
EcsURI(String location) {
- Preconditions.checkNotNull(location == null, "Location %s can not be
null", location);
+ Preconditions.checkNotNull(location, "Location %s can not be null",
location);
Review Comment:
Thank you. Since the check only fails when location is null, the %s always
rendered as "null", making the message read "Location null can not be null".
Changed to Preconditions.checkNotNull(location, "Location can not be null").
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
