kevinjqliu commented on code in PR #3547:
URL: https://github.com/apache/iceberg-python/pull/3547#discussion_r3449763936
##########
tests/expressions/test_evaluator.py:
##########
@@ -1528,43 +1614,6 @@ def test_strict_integer_not_in(strict_data_file_schema:
Schema, strict_data_file
should_read = _StrictMetricsEvaluator(strict_data_file_schema,
NotIn("no_nulls", {"abc", "def"})).eval(strict_data_file_1)
assert not should_read, "Should not match: no_nulls field does not have
bounds"
-
-def test_strict_not_eq_partial_nulls_within_bounds() -> None:
Review Comment:
Removed `test_strict_not_eq_partial_nulls_within_bounds` because the new
branch-focused tests cover the same partial-null boundary more directly, and
also add the missing all-null, mixed-NaN, and all-NaN cases. The removed test
also used singleton `NotIn("x", {5})`, which normalizes to `NotEqualTo("x", 5)`
and therefore did not exercise the strict `visit_not_in` branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
