thswlsqls opened a new pull request, #16918:
URL: https://github.com/apache/iceberg/pull/16918
Closes #16134
## Summary
- Add `HiveCatalog(Configuration, Map)` that calls `setConf(conf)` then
`initialize("hive", properties)`, so callers configure a catalog in one step
instead of new + setConf + initialize.
- Mirrors the existing `HadoopCatalog(Configuration, String)` anchor in core.
- Adds constructor Javadoc, cross-referenced from `setConf`/`initialize`.
- Revives stale-bot-closed PR #16135 (committer-approved "LGTM +1" by
deniskuzZ). Original author: 1fanwang.
## Testing done
- Added `TestHiveCatalog#testConstructorWithConfAndProperties`, asserting
`getConf()` retains the URI, warehouse, and a custom caller key (expected
values read from the inputs, not hardcoded).
- `./gradlew :iceberg-hive-metastore:check` passed on JDK 21 — 309 tests, 0
failures, including spotlessCheck, checkstyle, errorProne, and in-process HMS
(Derby) tests.
- This module is not a REVAPI target, so no revapi run.
Note: this adds public API, so a committer waits 24h before merge for
feedback.
---
**AI Disclosure**
- Model: Claude Opus 4.8
- Platform/Tool: Claude Code
- Human Oversight: fully reviewed
- Prompt Summary: Implement the committer-approved change from stale PR
#16135 — add a HiveCatalog(Configuration, Map) convenience constructor
mirroring HadoopCatalog, with a unit test verifying conf/properties are
retained.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
