fallintoplace opened a new issue, #1247: URL: https://github.com/apache/iceberg-go/issues/1247
ParquetFileWriter.Abort currently closes the underlying file handle but does not remove the partially written file. That avoids finalizing an invalid Parquet footer, but on object/blob backends it can leave a footer-less orphan object behind. This is pre-existing and also applies to RollingDataWriter's deferred abort path. Readers should not see the object because the snapshot is never committed, but storage is still left for orphan cleanup to find later. Expected behavior: - Abort closes the open writer/file handle. - Abort removes the incomplete file path from the FileIO. - If close and remove both fail, return both errors, for example with errors.Join. This would be closer to Java's BaseTaskWriter.abort behavior. Suggested tests: - Abort removes the created file. - Remove errors are returned. - RollingDataWriter abort removes the incomplete current file, if practical. Severity: 55/100 Product needed: 0/100 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
