vladislav-sidorovich commented on PR #15407: URL: https://github.com/apache/iceberg/pull/15407#issuecomment-4766826100
I went though the comments and the code. Let me sum-up the current state: 1. The code was/is ready for next review cycle. Some comments are not resolved because I would like an aka (and resolve) from the author. 2. There is backlog to add more features to the module according to the plan in the PR description. 3. The current version works and functional (with known limitations). I believe it's more pragmatic to get an alignment with community on the current version before increasing the code base with additional logic. @anoopj 1. The concern regarding usage of internal delta API is actual and valid. As we agreed yearly, I will finish full conversion logic and then collect the full list of the internal API. With the list we will decide if it will be contribution to DeltaKernel or some in-house replacement. @HonahX 1. I left the comments regarding VACUUM tests. The tests are robust 1. I left the comment regarding VACUUM logic handling 1. All data types (including Variant) tests in unit test. I left the comment. @laskoviymishka 1. Topic about `validate-from snapshot to currentSnapshot() ` - is not completely clear to me. So, it can be some work here. 1. Testing of deletion vectors per version explained (there is integration test). 1. The `blocker` from the big summary comment: 1.1 DV-update - resolved 1.2 Per-ColumnarBatch commits break - fixed 1.3 Unhandled metaData/protocol actions - fixed 1.4 DV test asserts presence - explained @anoopj @HonahX @laskoviymishka I would love to get next cycle of your review and input. Thank you for the contributions to the PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
