wgtmac commented on code in PR #708:
URL: https://github.com/apache/iceberg-cpp/pull/708#discussion_r3451222412
##########
src/iceberg/puffin/puffin_writer.cc:
##########
@@ -152,10 +152,10 @@ Status PuffinWriter::Finish() {
ICEBERG_ASSIGN_OR_RAISE(auto end_pos, stream_->Position());
footer_size_ = end_pos - footer_start;
+ file_size_ = end_pos;
footer_written_ = true;
ICEBERG_RETURN_UNEXPECTED(stream_->Flush());
ICEBERG_RETURN_UNEXPECTED(stream_->Close());
- ICEBERG_ASSIGN_OR_RAISE(file_size_, stream_->Position());
Review Comment:
I remember that this is an intentional design because Java puffin writer
will append some bytes after close in some cases that we haven't implemented so
far.
##########
src/iceberg/meson.build:
##########
@@ -49,6 +49,7 @@ iceberg_sources = files(
'catalog/session_catalog.cc',
'catalog/session_context.cc',
'delete_file_index.cc',
+ 'deletes/roaring_position_bitmap.cc',
Review Comment:
Perhaps we need to move it out of the `deletes` subdirectory.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
