mbutrovich commented on PR #15470: URL: https://github.com/apache/iceberg/pull/15470#issuecomment-4770647418
> looked at the code; all LGTM. that leave's @kevinjqliu's concerns about duplicate file writes to the same path. Thanks @steveloughran. @kevinjqliu's duplicate-write concern is fixed in bbbe4666: the rewrite phase dedupes physical files by `location()` ([RewriteTablePathSparkAction.java#L758-L769](https://github.com/mbutrovich/iceberg/blob/bbbe4666f794f143eda26fa55f0ef009047b20f3/spark/v4.1/spark/src/main/java/org/apache/iceberg/spark/actions/RewriteTablePathSparkAction.java#L758-L769)), so a Puffin file holding multiple DVs is written once while each manifest entry still gets the right size. Regression test: [testSharedPuffinDeleteFileSizeAfterRewrite](https://github.com/mbutrovich/iceberg/blob/bbbe4666f794f143eda26fa55f0ef009047b20f3/spark/v4.1/spark/src/test/java/org/apache/iceberg/spark/actions/TestRewriteTablePathsAction.java#L865). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
