fallintoplace opened a new pull request, #1256: URL: https://github.com/apache/iceberg-go/pull/1256
Summary - add a shared WriteFileIO requirement helper for table write paths - replace unchecked transaction WriteFileIO assertions with normal errors - return the same sentinel from row delta, equality-delete, and WriteRecords write-IO checks - add regression coverage for append, overwrite, copy-on-write delete, and row delta with a read-only FileIO Why Custom FileIO implementations can satisfy io.IO without supporting writes. A few table write paths still used direct WriteFileIO assertions, so a read-only implementation could panic instead of returning an error. Testing - go test ./table -run 'TestWritePathsReturnErrorForReadOnlyIO|TestDoCommit_NonWriteFileIOReturnsError|TestWriteRecords' -count=1\n- go test ./table -count=1\n- go run github.com/golangci/golangci-lint/v2/cmd/[email protected] run --timeout=10m ./table/...\n- git diff --check -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
